warn if General is installed via the old slow methods #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/warn_old_general
branch
from
42ea948
to
8d702cf
Compare
IanButterworth
commented
Sep 18, 2024
IanButterworth
force-pushed
the
ib/warn_old_general
branch
from
55c4ab3
to
fa10628
Compare
IanButterworth
force-pushed
the
ib/warn_old_general
branch
from
fa10628
to
134f3eb
Compare
|
Seems like a good idea. |
|
I'll add an env var disable just in case there are people that wish to stick with the old format. |
IanButterworth
added a commit
that referenced
this pull request
Oct 4, 2024
* warn if General is installed via the old slow methods * add env var disable (cherry picked from commit acc54fc)
14 tasks
IanButterworth
added a commit
that referenced
this pull request
Oct 5, 2024
* warn if General is installed via the old slow methods * add env var disable (cherry picked from commit acc54fc)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing https://discourse.julialang.org/t/adding-package-to-new-environment-takes-long-time/119518/5 makes me wonder how many people out there might be stuck with General installed via the old methods, so this adds a note if so.
I can't imagine anyone intentionally uses either on newer versions for General..If anyone is intentionally using an old format this check can be disabled via
JULIA_PKG_GEN_REG_FMT_CHECK=0