Make Pkg more robust to poor inference #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few things in Pkg rely on inference to figure out (empty) collection types and error if inference can't figure it because the subsequent method signatures are narrow. I wouldn't really care for any other package, but when working on inference it's not uncommon for it to temporarily be somewhat broken. It's useful to still have Pkg available so that the build finishes and that it is possible to install extra packages for debugging.
IanButterworth
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Oct 13, 2024
Includes changes from JuliaLang/Pkg.jl#4038 and JuliaLang/Pkg.jl#4044. Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things in Pkg rely on inference to figure out (empty) collection types and error if inference can't figure it because the subsequent method signatures are narrow.
I wouldn't really care for any other package, but when working on inference it's not uncommon for it to temporarily be somewhat broken. It's useful to still have Pkg available so that the build finishes and that it is possible to install extra packages for debugging.