Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix end of progress bar #4045

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Conversation

christiangnrd
Copy link
Contributor

@christiangnrd christiangnrd commented Oct 12, 2024

The progress bar would "bounce" by not printing any :light_black characters when n_left == 0 but n_filled != max_progress_width.

#Before
julia> bar.current=980;show_progress(stdout,bar)
 Downloading packages ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╺ 980/1000
#After
julia> bar.current=980;show_progress(stdout,bar)
 Downloading packages ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 980/1000

@IanButterworth IanButterworth merged commit 9e37e1b into JuliaLang:master Oct 13, 2024
7 checks passed
@christiangnrd christiangnrd deleted the patch-1 branch October 13, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants