Stear the user towards let

[vchuravy]

begin is a soft-scope so global variables created within are rooted through the module.

Instead users should use let so that the setup data is GC'd and not serialized into the cache file.

[timholy]

Agreed. But I've found that using let sometimes negates the benefits of @compile_workload, I'm guessing because let is more likely to trigger compilation before one reaches

PrecompileTools.jl/src/workloads.jl

Line 91 in a994463

Core.Compiler.__set_measure_typeinf(true)

. If it compiles the whole let block before executing it, that's trouble.

[timholy]

The right way to check this would be to have a workload that includes a runtime-dispatched call to a non-precompiled method in another package. A little annoying to set up as a test but just giving it a whirl and seeing what happens shouldn't be too hard.