Refine test specific dependencies #52477
Open
+24
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Feb 6, 2024
I ran into a bug affecting Julia 1.9.4 and older where non registered packages being depended on by both the Packages and it's test suite. This bug has been fixed for 1.10.x independently but i might still have to rewrite the test suite from the alternative approach pseudo project approach to the target approach. I hope these changes to the documentation reflect the current lack of clarity surrounding the usability of the new approach and give more insight in general. Some general editing was performed.
fingolfin
reviewed
Feb 12, 2024
|
|
||
| #### `target` based test specific dependencies | ||
|
|
||
| Using this method of adding test-specific dependencies, the packages are added under an `[extras]` section and to a test target, | ||
| e.g. to add `Markdown` and `Test` as test dependencies, add the following to the `Project.toml` file: | ||
| !!! compat |
There was a problem hiding this comment.
I would expect this compat notice after the explanation of what the target method does
There was a problem hiding this comment.
As this is directly related to the decision what functionality to choose, i could see that compat block being useful before further explanations.
That said. I don't care.
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
kimikage
reviewed
May 24, 2024
| @@ -340,7 +340,7 @@ julia> write("test/runtests.jl", | |||
| @test 1 == 1 | |||
| """); | |||
|
|
|||
| (test) pkg> activate . | |||
| (test) pkg> activate | |||
There was a problem hiding this comment.
The removed does not appear to be "white spaces".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a bug affecting Julia 1.9.4 and some older version where non registered packages being depended on by both the Packages and it's test suite result in a situation where there is no way to tweak the two involved
Project.tomls to get the tests to run.This bug might have been fixed for 1.10.x independently in Pkg.jl JuliaLang/Pkg.jl#3410 . I might still have to rewrite the test suite from the alternative pseudo project approach to the traditional target approach. I hope these changes to the documentation reflect the current lack of clarity surrounding the practicality of the new approach. Some general editing was performed to add info and move info to the section where it fits best. Building on JuliaLang/Pkg.jl#3535
I was not bold enough to generally recommend against the "alternative pseudo project approach" as i have no idea how actively fixes to how
Project.tomlare handled are backported to still supported Julia versions.The Pkg.jl maintainers should also comment as this file is also shown in their documentation.