Fixing the //(x::Number, y::Complex) one liner to accomodate silent overflows and division by zero/infinity #56478
+34
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
rationals
nhz2
reviewed
Nov 6, 2024
Comment on lines
+108
to
+110
| if isinf(real(y)) || isinf(imag(y)) | ||
| return 0//1 | ||
| end |
There was a problem hiding this comment.
If y is a complex integer isn't isinf here always false?
There was a problem hiding this comment.
In issue #56245 the errors were thrown for "incorrectly assumes y is finite and nonzero" so I added conditions for for infinite and 0.
base/rational.jl
Outdated
| end | ||
| real_y = real(y) | ||
| imag_y = imag(y) | ||
| denom = Int32(abs(real_y))^2 + Int32(abs(imag_y))^2 |
There was a problem hiding this comment.
I added that to account for any overflow, but int16 would work perfectly fine as well!
There was a problem hiding this comment.
Hey, I’ve implemented scaling to prevent any overflow in calculations (removing any need for INT32. Could you take a look at my approach
applied scaling while calculating absolute values in order to prevent overflow at any step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53435 Fixes #56245. I have added conditions for division by zero and infinite handling in the case of complex numbers and overflow handling in the case of integer-based complex numbers. Further, I have added a few tests for the same :)