Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the //(x::Number, y::Complex) one liner to accomodate silent overflows and division by zero/infinity #56478

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixing the //(x::Number, y::Complex) one liner to accomodate silent overflows and division by zero/infinity #56478

wants to merge 4 commits into from
+33 −4

Commits on Nov 6, 2024

  1. Add two test files

    Priynsh committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a10ccb1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'JuliaLang:master' into rationaloverflow

    @Priynsh
    Priynsh authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b3bb6c5 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Update rational.jl 

    applied scaling while calculating absolute values in order to prevent overflow at any step
    @Priynsh
    Priynsh authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    87e2284 View commit details
    Browse the repository at this point in the history

  2. Update rational.jl 

    fixed the overflow issue in my solution, implemented iszero and isinf wherever possible for lighter implementation
    @Priynsh
    Priynsh authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3879186 View commit details
    Browse the repository at this point in the history