Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing RNG instance to splitobs() for shuffle control #179

Open
abhro opened this issue Oct 23, 2024 · 2 comments
Open

Allow passing RNG instance to splitobs() for shuffle control #179

abhro opened this issue Oct 23, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@abhro
Copy link

abhro commented Oct 23, 2024

splitobs() allows shuffling of data, but the randomization cannot be controlled by passing in a user-specified RNG. shuffleobs() does support this, but this functionality is not exploited by splitobs().
@ToucheSir ToucheSir added enhancement New feature or request good first issue Good for newcomers labels Oct 23, 2024
@CarloLucibello
Copy link
Member

@abhro a PR would be welcome if you have time

@abhro
Copy link
Author

abhro commented Oct 25, 2024

Honestly, I'd love to have a crack at it, but right now I might end up needing the feature sooner than I can implement it. Would love for anyone else's attempt at it though 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ToucheSir @abhro @CarloLucibello