Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sketch change metric. #423

Merged
merged 49 commits into from
Sep 22, 2021
Merged

Sketch change metric. #423

merged 49 commits into from
Sep 22, 2021

Commits on Sep 10, 2021

  1. Sketch change metric.

    @kellertuer
    kellertuer committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    ae0cdd1 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2021

  1. Document insights from yesterday evening and – getting stuck at the n… 

    …ext point.
    @kellertuer
    kellertuer committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    3347930 View commit details
    Browse the repository at this point in the history

  2. rfF.

    @kellertuer
    kellertuer committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    a302733 View commit details
    Browse the repository at this point in the history

  3. fix a few typos.

    @kellertuer
    kellertuer committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    0857b21 View commit details
    Browse the repository at this point in the history

  4. adds a change_gradient.

    @kellertuer
    kellertuer committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    c9737b3 View commit details
    Browse the repository at this point in the history

  5. Fix a few typos in docs.

    @kellertuer
    kellertuer committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    616db5d View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    158bbf2 View commit details
    Browse the repository at this point in the history

  7. Update src/manifolds/MetricManifold.jl 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    056e24c View commit details
    Browse the repository at this point in the history

  8. Specify Reisz representer, change adjoint to ^H.

    @kellertuer
    kellertuer committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    540f374 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'kellertuer/gradient-conversion' of github.com:JuliaMani… 

    …folds/Manifolds.jl into kellertuer/gradient-conversion

# Conflicts:
#	src/manifolds/MetricManifold.jl
    @kellertuer
    kellertuer committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    a17b4ca View commit details
    Browse the repository at this point in the history

  10. Fix two typos.

    @kellertuer
    kellertuer committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    c742ea5 View commit details
    Browse the repository at this point in the history

  11. Update src/manifolds/MetricManifold.jl 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    2ee2072 View commit details
    Browse the repository at this point in the history

  12. adds a few conversion, where the embedding is not isometric.

    @kellertuer
    kellertuer committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    cb2f932 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'kellertuer/gradient-conversion' of github.com:JuliaMani… 

    …folds/Manifolds.jl into kellertuer/gradient-conversion
    @kellertuer
    kellertuer committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    fb304c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2021

  1. implement the remaining conversions.

    @kellertuer
    kellertuer committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    42875a6 View commit details
    Browse the repository at this point in the history

  2. add the generic case for doubly stochastic (includes symmetric, too).

    @kellertuer
    kellertuer committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    9769a1a View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Sep 12, 2021
    Configuration menu
    Copy the full SHA
    05968dc View commit details
    Browse the repository at this point in the history

  4. Adress points from code review.

    @kellertuer
    kellertuer committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    4912e4f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'kellertuer/gradient-conversion' of github.com:JuliaMani… 

    …folds/Manifolds.jl into kellertuer/gradient-conversion
    @kellertuer
    kellertuer committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    714862e View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. introduce mutating variants and decorator transparency.

    @kellertuer
    kellertuer committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    5539f4b View commit details
    Browse the repository at this point in the history

  2. Change change_gradient to change_represender and introduce mutati… 

    …ng variant
    @kellertuer
    kellertuer committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    2eac3ee View commit details
    Browse the repository at this point in the history

  3. Fix two typos.

    @kellertuer
    kellertuer committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    1b79065 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. fix transparency of nonmutating to parent on a Manifold level.

    @kellertuer
    kellertuer committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    152e9a1 View commit details
    Browse the repository at this point in the history

  2. Finish documentation and test for Generalised Grassmann.

    @kellertuer
    kellertuer committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    257b223 View commit details
    Browse the repository at this point in the history

  3. Document and test hyperbolic.

    @kellertuer
    kellertuer committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    ea76128 View commit details
    Browse the repository at this point in the history

  4. adds two further small tests.

    @kellertuer
    kellertuer committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    d84a3cc View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Documentation and Test for Poincaré Ball conversion.

    @kellertuer
    kellertuer committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    a62e134 View commit details
    Browse the repository at this point in the history

  2. fix a small bug in Hyperbolic copyto! which returned the wrong value.

    @kellertuer
    kellertuer committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    6f1fb64 View commit details
    Browse the repository at this point in the history

  3. finishes testing for hyperbolic.

    @kellertuer
    kellertuer committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    95b8bc6 View commit details
    Browse the repository at this point in the history

  4. delete change_representer since it should be inherited from Probabili… 

    …tySimplex combined with AbstractPowerManifold and EmbeddedManifold.
    @kellertuer
    kellertuer committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    6300f80 View commit details
    Browse the repository at this point in the history

  5. Extend ProbabilitySimples to also cover change_metric.

    @kellertuer
    kellertuer committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    7737c92 View commit details
    Browse the repository at this point in the history

  6. Finish positive Numbers.

    @kellertuer
    kellertuer committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    d2cec4d View commit details
    Browse the repository at this point in the history

  7. Document and test SPDs

    @kellertuer
    kellertuer committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    5005965 View commit details
    Browse the repository at this point in the history

  8. Fixes a few typos in the docs.

    @kellertuer
    kellertuer committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    844f8c4 View commit details
    Browse the repository at this point in the history

  9. finish tests for product and power – extend features to also work on … 

    …the sphere.
    @kellertuer
    kellertuer committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    c154516 View commit details
    Browse the repository at this point in the history

  10. append this step to riemannian differentiation.

    @kellertuer
    kellertuer committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    da98b5f View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into kellertuer/gradient-conversion

    @kellertuer
    kellertuer committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    cbcef94 View commit details
    Browse the repository at this point in the history

  12. bump version.

    @kellertuer
    kellertuer committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    14fdb06 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Sep 16, 2021
    Configuration menu
    Copy the full SHA
    d1dbb7c View commit details
    Browse the repository at this point in the history

  2. adds a test for positive vectors and starts testing the default Metri… 

    …c fallbacks using the local metric.
    @kellertuer
    kellertuer committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    95a3c8b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'kellertuer/gradient-conversion' of github.com:JuliaMani… 

    …folds/Manifolds.jl into kellertuer/gradient-conversion
    @kellertuer
    kellertuer committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    d34ef6c View commit details
    Browse the repository at this point in the history

  4. Improve docs.

    @kellertuer
    kellertuer committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    97417ae View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. Maybe. just maybe fixed local metric, but now get vector and get coor… 

    …dinates do not work for the test.
    @kellertuer
    kellertuer committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    a78ace4 View commit details
    Browse the repository at this point in the history

  2. format this interims non-working test.

    @kellertuer
    kellertuer committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    49dc500 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2021

  1. maybe fix the new test by slightly overtyping the basis.

    @kellertuer
    kellertuer committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    ed2871c View commit details
    Browse the repository at this point in the history

  2. Fix the error message for hyperbolic.

    @kellertuer
    kellertuer committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    420047d View commit details
    Browse the repository at this point in the history

  3. Simplify default implementation. Extend coverage. Order functions alp… 

    …habetically.
    @kellertuer
    kellertuer committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    e180bc4 View commit details
    Browse the repository at this point in the history

  4. add a test that double metric wrapping is avoided; remove unnecessary… 

    … dispatch.
    @kellertuer
    kellertuer committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    2f498da View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Sep 22, 2021
    Configuration menu
    Copy the full SHA
    4501a27 View commit details
    Browse the repository at this point in the history