Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularise Constraints #386

Merged
merged 107 commits into from
Jun 8, 2024
Merged

Modularise Constraints #386

merged 107 commits into from
Jun 8, 2024

Commits on May 4, 2024

  1. Start structural rework on constraint objectives.

    @kellertuer
    kellertuer committed May 4, 2024
    Configuration menu
    Copy the full SHA
    56eb725 View commit details
    Browse the repository at this point in the history

  2. Sketch the idea of a unified vector function objective.

    @kellertuer
    kellertuer committed May 4, 2024
    Configuration menu
    Copy the full SHA
    147cf4e View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Rename the VectorialObjective to a VectorGradientFunction and start i… 

    …mplementing accessors.
    @kellertuer
    kellertuer committed May 6, 2024
    Configuration menu
    Copy the full SHA
    bde4510 View commit details
    Browse the repository at this point in the history

  2. Reduce duplicate text.

    @kellertuer
    kellertuer committed May 6, 2024
    Configuration menu
    Copy the full SHA
    40235f4 View commit details
    Browse the repository at this point in the history

  3. Finish most of the desugn and basic documentation work.

    @kellertuer
    kellertuer committed May 6, 2024
    Configuration menu
    Copy the full SHA
    c060302 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored May 7, 2024
    Configuration menu
    Copy the full SHA
    88d81f1 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'master' into kellertuer/structural_rework_constraints

    @kellertuer
    kellertuer committed May 8, 2024
    Configuration menu
    Copy the full SHA
    6862c92 View commit details
    Browse the repository at this point in the history

  2. sketch all variants of the (full) access get_gradients and get_gradie… 

    …nts!
    @kellertuer
    kellertuer committed May 8, 2024
    Configuration menu
    Copy the full SHA
    bd3fec3 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Merge branch 'master' into kellertuer/structural_rework_constraints

    @mateuszbaran
    mateuszbaran committed May 10, 2024
    Configuration menu
    Copy the full SHA
    879e94a View commit details
    Browse the repository at this point in the history

  2. minor fixes

    @mateuszbaran
    mateuszbaran committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4b6eac7 View commit details
    Browse the repository at this point in the history

  3. Update src/plans/constrained_plan.jl 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @mateuszbaran @github-actions
    mateuszbaran and github-actions[bot] authored May 10, 2024
    Configuration menu
    Copy the full SHA
    7826cd4 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Sketch new plan with range (similar to domain) being in the Problem.

    @kellertuer
    kellertuer committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8cb0379 View commit details
    Browse the repository at this point in the history

  2. finish gradient index access.

    @kellertuer
    kellertuer committed May 15, 2024
    Configuration menu
    Copy the full SHA
    718e462 View commit details
    Browse the repository at this point in the history

  3. finish work for today.

    @kellertuer
    kellertuer committed May 15, 2024
    Configuration menu
    Copy the full SHA
    2cb0ac3 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. A bit of vale improvements.

    @kellertuer
    kellertuer committed May 16, 2024
    Configuration menu
    Copy the full SHA
    0b98891 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Refactor 

    * `grad_x_gradients` is now a `get_gradient` with `Colon`for the new Vectorfunction
* `range` now only stores the abstract powerrepresentation
    @kellertuer
    kellertuer committed May 17, 2024
    Configuration menu
    Copy the full SHA
    57523b0 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. A bit of vale improvements.

    @kellertuer
    kellertuer committed May 18, 2024
    Configuration menu
    Copy the full SHA
    d8b2a06 View commit details
    Browse the repository at this point in the history

  2. Implement more generic index access.

    @kellertuer
    kellertuer committed May 18, 2024
    Configuration menu
    Copy the full SHA
    0cf98d6 View commit details
    Browse the repository at this point in the history

  3. Refactor inequality and equality access functions for the objective.

    @kellertuer
    kellertuer committed May 18, 2024
    Configuration menu
    Copy the full SHA
    3a57084 View commit details
    Browse the repository at this point in the history

  4. Fix a few bugs in types (from the time where the VecFun was still an … 

    …Objective)
    @kellertuer
    kellertuer committed May 18, 2024
    Configuration menu
    Copy the full SHA
    04dc9e4 View commit details
    Browse the repository at this point in the history

  5. remove a few prints.

    @kellertuer
    kellertuer committed May 18, 2024
    Configuration menu
    Copy the full SHA
    c7a8c48 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Fix most of the tests.

    @kellertuer
    kellertuer committed May 19, 2024
    Configuration menu
    Copy the full SHA
    3c4b9b5 View commit details
    Browse the repository at this point in the history

  2. rename one further test.

    @kellertuer
    kellertuer committed May 19, 2024
    Configuration menu
    Copy the full SHA
    c4169fe View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Fix a few more tests and introduce some high-level parts.

    @kellertuer
    kellertuer committed May 20, 2024
    Configuration menu
    Copy the full SHA
    727d68c View commit details
    Browse the repository at this point in the history

  2. fix EPM and half of ALM

    @mateuszbaran
    mateuszbaran committed May 20, 2024
    Configuration menu
    Copy the full SHA
    67f2a7f View commit details
    Browse the repository at this point in the history

  3. fix ALM

    @mateuszbaran
    mateuszbaran committed May 20, 2024
    Configuration menu
    Copy the full SHA
    e2de6ff View commit details
    Browse the repository at this point in the history

  4. another small convenience fix.

    @kellertuer
    kellertuer committed May 20, 2024
    Configuration menu
    Copy the full SHA
    6095c3e View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. A bit of code refinements and started working on the count interactions.

    @kellertuer
    kellertuer committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ff2418e View commit details
    Browse the repository at this point in the history

  2. Resolve an Aqua error and another set of warnings.

    @kellertuer
    kellertuer committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7524287 View commit details
    Browse the repository at this point in the history

  3. Fix a few easier bugs and typos.

    @kellertuer
    kellertuer committed May 21, 2024
    Configuration menu
    Copy the full SHA
    82f2bd5 View commit details
    Browse the repository at this point in the history

  4. Update test/plans/test_constrained_plan.jl 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored May 21, 2024
    Configuration menu
    Copy the full SHA
    e02b0d6 View commit details
    Browse the repository at this point in the history

  5. rename get-cost to get_value for the VectorGradientFunction.

    @kellertuer
    kellertuer committed May 21, 2024
    Configuration menu
    Copy the full SHA
    76856f8 View commit details
    Browse the repository at this point in the history

  6. Change show() for the constrained objective.

    @kellertuer
    kellertuer committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b6d77e1 View commit details
    Browse the repository at this point in the history

  7. Und mühsam ernährt sich das Eichhörnchen.

    @kellertuer
    kellertuer committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c242b1d View commit details
    Browse the repository at this point in the history

  8. fix some cases of get_gradient!

    @mateuszbaran
    mateuszbaran committed May 21, 2024
    Configuration menu
    Copy the full SHA
    dfc0bd4 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. docs for to_iterable_indices

    @mateuszbaran
    mateuszbaran committed May 22, 2024
    Configuration menu
    Copy the full SHA
    45e3eab View commit details
    Browse the repository at this point in the history

  2. Base.length but why?

    @mateuszbaran
    mateuszbaran committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1f57b8b View commit details
    Browse the repository at this point in the history

  3. Maybe fix julia 1.9? No clue why the other Base methods to not need t… 

    …he explicit Base. prefix, but _with_ that Manopt suddenly compiles on 1.9 – strange magic.
    @kellertuer
    kellertuer committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2d669a3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'kellertuer/structural_rework_constraints' of github.com… 

    …:JuliaManifolds/Manopt.jl into kellertuer/structural_rework_constraints
    @kellertuer
    kellertuer committed May 22, 2024
    Configuration menu
    Copy the full SHA
    862b71f View commit details
    Browse the repository at this point in the history

  5. depwarn

    @mateuszbaran
    mateuszbaran committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8f8b2ab View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Remove a bit of unnecessary Code.

    @kellertuer
    kellertuer committed May 23, 2024
    Configuration menu
    Copy the full SHA
    52bec6c View commit details
    Browse the repository at this point in the history

  2. Fix tests.

    @kellertuer
    kellertuer committed May 23, 2024
    Configuration menu
    Copy the full SHA
    807c020 View commit details
    Browse the repository at this point in the history

  3. A bit of work on the docs.

    @kellertuer
    kellertuer committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f18716b View commit details
    Browse the repository at this point in the history

  4. Update and fix documentation.

    @kellertuer
    kellertuer committed May 23, 2024
    Configuration menu
    Copy the full SHA
    bbb6d24 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. First sketch idea with new indices?

    @kellertuer
    kellertuer committed May 24, 2024
    Configuration menu
    Copy the full SHA
    c8ee68b View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. some fixes

    @mateuszbaran
    mateuszbaran committed May 26, 2024
    Configuration menu
    Copy the full SHA
    9a97bc2 View commit details
    Browse the repository at this point in the history

  2. A bit of vale.

    @kellertuer
    kellertuer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    3a4c624 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'kellertuer/structural_rework_constraints' of github.com… 

    …:JuliaManifolds/Manopt.jl into kellertuer/structural_rework_constraints
    @kellertuer
    kellertuer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    570a381 View commit details
    Browse the repository at this point in the history

  4. introduce two further length methods.

    @kellertuer
    kellertuer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    956020d View commit details
    Browse the repository at this point in the history

  5. Carefully implement all extended cache functions for constrained obje… 

    …ctives.
    @kellertuer
    kellertuer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    b82f792 View commit details
    Browse the repository at this point in the history

  6. Implement the new constraint adressing also for count.

    @kellertuer
    kellertuer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    667781d View commit details
    Browse the repository at this point in the history

  7. Update docs.

    @kellertuer
    kellertuer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    4c0a7b5 View commit details
    Browse the repository at this point in the history

  8. Replace X[pM, k] with the corresponding _write. Runs formatter.

    @kellertuer
    kellertuer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    a47fc9f View commit details
    Browse the repository at this point in the history

  9. 📈

    @kellertuer
    kellertuer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    6645647 View commit details
    Browse the repository at this point in the history

  10. 📈VectorGradientFunction

    @kellertuer
    kellertuer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    352f4d6 View commit details
    Browse the repository at this point in the history

  11. move an unnecessary function.

    @kellertuer
    kellertuer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    83a674c View commit details
    Browse the repository at this point in the history

  12. Add one further test.

    @kellertuer
    kellertuer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    9bf1f1a View commit details
    Browse the repository at this point in the history

  13. runs formatter.

    @kellertuer
    kellertuer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    4f59cee View commit details
    Browse the repository at this point in the history

  14. A bit of vale.

    @kellertuer
    kellertuer committed May 26, 2024
    Configuration menu
    Copy the full SHA
    7803ce3 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Finally tricked vale into working fine. 

    Circumventing a few bugs.
    @kellertuer
    kellertuer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    230a0dc View commit details
    Browse the repository at this point in the history

  2. 📈VGF 

    and rename the CoefficientType to CoordinateType, since that is more consistent.
    @kellertuer
    kellertuer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    ee973e7 View commit details
    Browse the repository at this point in the history

  3. 📈📈 Cache & Count

    @kellertuer
    kellertuer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    a28d6b6 View commit details
    Browse the repository at this point in the history

  4. Fix a typo tweak vale a bit.

    @kellertuer
    kellertuer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    6c84006 View commit details
    Browse the repository at this point in the history

  5. Hitting a few more cache misses.

    @kellertuer
    kellertuer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    605d631 View commit details
    Browse the repository at this point in the history

  6. Refactor tests a bit and hopefully trigger the last few cache misses.

    @kellertuer
    kellertuer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    5392012 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Add the range to the constraint algorithms high level interfaces.

    @kellertuer
    kellertuer committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d85a3dd View commit details
    Browse the repository at this point in the history

  2. Update Changelog.

    @kellertuer
    kellertuer committed May 28, 2024
    Configuration menu
    Copy the full SHA
    3fd11d9 View commit details
    Browse the repository at this point in the history

  3. Fix a final todo.

    @kellertuer
    kellertuer committed May 28, 2024
    Configuration menu
    Copy the full SHA
    333978d View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Sketch Hessian vector function.

    @kellertuer
    kellertuer committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    082c5f4 View commit details
    Browse the repository at this point in the history

  2. Introduce next higher level functions in the objeective.

    @kellertuer
    kellertuer committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    b0cc6d1 View commit details
    Browse the repository at this point in the history

  3. Update src/plans/vectorial_plan.jl 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @kellertuer @github-actions
    kellertuer and github-actions[bot] authored Jun 1, 2024
    Configuration menu
    Copy the full SHA
    deee504 View commit details
    Browse the repository at this point in the history

  4. frmps.

    @kellertuer
    kellertuer committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    4ccecc3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'kellertuer/structural_rework_constraints' of github.com… 

    …:JuliaManifolds/Manopt.jl into kellertuer/structural_rework_constraints
    @kellertuer
    kellertuer committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    599994d View commit details
    Browse the repository at this point in the history

  6. extend Constructor

    @kellertuer
    kellertuer committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    33a4e5f View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. Fix ambiguities by being super super super precise in parameters.

    @kellertuer
    kellertuer committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    66563d0 View commit details
    Browse the repository at this point in the history

  2. Fix / extend documenation.

    @kellertuer
    kellertuer committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    b915b8f View commit details
    Browse the repository at this point in the history

  3. Fix a few bugs.

    @kellertuer
    kellertuer committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    3766451 View commit details
    Browse the repository at this point in the history

  4. Fix a few bugs.

    @kellertuer
    kellertuer committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    910ac32 View commit details
    Browse the repository at this point in the history

  5. increase test coverage.

    @kellertuer
    kellertuer committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    c3080bc View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Remove unnecessary cases.

    @kellertuer
    kellertuer committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    6076b47 View commit details
    Browse the repository at this point in the history

  2. 📈 (again)

    @kellertuer
    kellertuer committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    88ea7bd View commit details
    Browse the repository at this point in the history

  3. 📈 on internal access functions.

    @kellertuer
    kellertuer committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    d4d3cd9 View commit details
    Browse the repository at this point in the history

  4. 📈 passthrough.

    @kellertuer
    kellertuer committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8638bcb View commit details
    Browse the repository at this point in the history

  5. 📈 special cases and fallbacks

    @kellertuer
    kellertuer committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    1b726c3 View commit details
    Browse the repository at this point in the history

  6. allow eigendecomposition and add type for range

    @mateuszbaran
    mateuszbaran committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    db988e0 View commit details
    Browse the repository at this point in the history

  7. restrict some types a bit

    @mateuszbaran
    mateuszbaran committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    fe2681c View commit details
    Browse the repository at this point in the history

  8. vectorial_plan.jl aktualisieren 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    2f4703e View commit details
    Browse the repository at this point in the history

  9. Document the inequality and equality constraint number thoroughly and… 

    … make it a bit nicer using `nothing` as default instead of -1.
    @kellertuer
    kellertuer committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8da02a2 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'kellertuer/structural_rework_constraints' of github.com… 

    …:JuliaManifolds/Manopt.jl into kellertuer/structural_rework_constraints
    @kellertuer
    kellertuer committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    3ad06a7 View commit details
    Browse the repository at this point in the history

  11. Update changelog and a bit of vale

    @kellertuer
    kellertuer committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8536cfb View commit details
    Browse the repository at this point in the history

  12. 📈(forgot some lines, hopefully things bring cc back).

    @kellertuer
    kellertuer committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    e6e2eec View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. fix typo

    @mateuszbaran
    mateuszbaran committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    36bd1da View commit details
    Browse the repository at this point in the history

  2. typo

    @mateuszbaran
    mateuszbaran committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    adc7bdb View commit details
    Browse the repository at this point in the history

  3. more typos

    @mateuszbaran
    mateuszbaran committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    305ea1c View commit details
    Browse the repository at this point in the history

  4. typos

    @mateuszbaran
    mateuszbaran committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    b06cfba View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    226755b View commit details
    Browse the repository at this point in the history

  6. add type upper bounds to ConstrainedManifoldObjective

    @mateuszbaran
    mateuszbaran committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    510d96b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into kellertuer/structural_rework_constraints 

    # Conflicts:
#	Changelog.md
    @kellertuer
    kellertuer committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    3ba73fc View commit details
    Browse the repository at this point in the history

  8. Merge branch 'kellertuer/structural_rework_constraints' of github.com… 

    …:JuliaManifolds/Manopt.jl into kellertuer/structural_rework_constraints
    @kellertuer
    kellertuer committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    fa7196a View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    03f06a4 View commit details
    Browse the repository at this point in the history

  10. Fix docs.

    @kellertuer
    kellertuer committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    33483f2 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'kellertuer/structural_rework_constraints' of github.com… 

    …:JuliaManifolds/Manopt.jl into kellertuer/structural_rework_constraints
    @kellertuer
    kellertuer committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    e25d82b View commit details
    Browse the repository at this point in the history

  12. Fix another llnk in the docs.

    @kellertuer
    kellertuer committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d228a86 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. minor improvements

    @mateuszbaran
    mateuszbaran committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    35a3a28 View commit details
    Browse the repository at this point in the history

  2. one more typo

    @mateuszbaran
    mateuszbaran committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d247fe7 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    bda6141 View commit details
    Browse the repository at this point in the history

  4. remove a few “-1” defaults I missed.

    @kellertuer
    kellertuer committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d7f1205 View commit details
    Browse the repository at this point in the history