Improve ElasticManager #203
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add callback mechanism. Allows users to automatically initialize new workers, add workers to a given worker pool, etc. * Make it easy to set worker timeout. * Add debug logging, often necessary to figure out worker connection problems.
Revise has Distributed support, workers shouldn't run Revise separately.
|
CC @JBlaschke , thanks for pointing out the potential of |
|
Will take a bit longer before I upstream the ElasticManager changes from ParallelProcessingTools, I want to see if there's a clean way to handle network device selection and if that requires interface changes. |
|
@DilumAluthge , sorry, I neglected this a bit, I should really get on with getting this release-ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds several things to ElasticManager:
An callback option - this can be used to automatically run init code on new workers, add them to and remove them from worker pools, add custom logging when workers connect, etc.
More debug logging - often necessary to find out what's wrong if workers won't connect.
Add a mechanism to forward environment variables to workers. Havent' found a way to set them before the Julia worker process starts up, but at least sets them before it does anything.
I'm field-testing this via a local copy of ElasticManager in ParallelProcessingTools.jl (will release a new version soon) so I can make breaking changes still if necessary, but I'll keep this PR in sync to upstream once it seems fully stable (looking pretty good so far, so hopefully soon).