-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiply legend_font_pointsize
by line_width
#4530
Conversation
ce1d47a
to
1731372
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean.. I don't like that scaling at all, but being consistent is better than not
Maybe multiply by |
I've arbitrarily clamped the legend It think clamping is required, since we want to avoid legend entries overlap. What are your thoughts on these values @BeastyBlacksmith ? using Plots
x = rand(10)
plot(x, lw=0.1)
plot(x, lw=5)
plot(x, lw=10) |
44404d8
to
92c6466
Compare
Looks reasonable 👍🏻 |
Codecov ReportBase: 91.08% // Head: 91.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4530 +/- ##
=======================================
Coverage 91.08% 91.09%
=======================================
Files 40 40
Lines 7683 7689 +6
=======================================
+ Hits 6998 7004 +6
Misses 685 685
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Can anybody share an example code how this problem has been solved? I don't quite get it. Thank you very much. @t-bltg @BeastyBlacksmith |
Fix #3003.
The inconsistency should be fixed.
Needs new reference images. Maybe we need some non-linearity or flag here to revert to non-scaling of legend line width. TBD.
PR
master
https://docs.juliaplots.org/dev/gallery/gr/generated/gr-ref1/#gr_demo_1