Fix border ticks of framestyle :box #4832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in Issue #2218 , when using the GR backend with attribute
framestyle = :box
, there are no ticks presents on the opposite side of border (border depends on attributemirror
). And PR #4488 has not solved the problem and closed the previous issue.Here I'm providing another small PR trying to fix the problem, which just add missing segements when drawing the plot with attribute
framestyle = :box
.Also mentioned by @BeastyBlacksmith in the issue, the behaviour of
:box
should be like that. However I'm not sure whether it is better to provides some attribute switches to control whether those ticks should be placed on the opposite side.Attribution
Things to consider