Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding uparrow as a predefined marker and creating unfilled markershapes #4977

Merged
merged 9 commits into from
Oct 9, 2024

Conversation

leckerbeon
Copy link
Contributor

Description

Adds :uparrow as a predefined markershape and causes markercolor=nothing to create an unfilled open shape as requested in #4962.
The changes also make it possible to create unfilled markers of every predefined markershape and also add an :downarrow shape.
Unfortunately I couldn´t quite figure out how to make sticks flip the marker shape vertically if the data value is less or equal to 0.0.

Attribution

Things to consider

  • Does it work on log scales?
  • Does it work in layouts?
  • Does it work in recipes?
  • Does it work with multiple series in one call?
  • PR includes or updates tests?
  • PR includes or updates documentation?

@BeastyBlacksmith BeastyBlacksmith linked an issue Sep 4, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.54%. Comparing base (19e3073) to head (8d09597).
Report is 1 commits behind head on v2.

Files with missing lines Patch % Lines
PlotsBase/src/Shapes.jl 0.00% 1 Missing ⚠️
PlotsBase/src/recipes.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #4977      +/-   ##
==========================================
+ Coverage   85.01%   86.54%   +1.53%     
==========================================
  Files          51       51              
  Lines        5985     5991       +6     
==========================================
+ Hits         5088     5185      +97     
+ Misses        897      806      -91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeastyBlacksmith BeastyBlacksmith merged commit f137efb into JuliaPlots:v2 Oct 9, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Sticks with arrow heads
2 participants