Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the 0th order density functions for the CB1972 basis return zero.$n=0$ then
$n=1$ , $\mu^l_n = \phi^{l+1}_n$ for $n<2$ .
I think this is because of the line
Dln = u2-u0
. IfgetUln
will just returnuact = UAzimuthalInitializationCB72(x,l)
, resulting inDln = 0.0
.Similarly for
Dln
will be offset byUAzimuthalInitializationCB72(x,l)
.To fix, I added a conditional to satisfy (3.14) of Clutton-Brock 1972 so that
Above is a plot showing the results before and after the fix.