broadcastable for Symbolics.
#495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaSymbolics/Symbolics.jl#455 , I noticed that `simplify(sum(x.^2))` would also fail. The error results from a call to `broadcastable` on the arguments of `(x.^2).value.term`. E.g., the first argument is a `Term{Any}` with `Ref` as operation and `^` as its sole argument. I have added a `broadcastable` for any `Symbolic` that catches this case and fallback to unspecialized broadcastable otherwise. See also JuliaSymbolics#409
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose the issue in JuliaSymbolics/Symbolics.jl#455 is fixed, e.g., via #493.
Then
simplify(sum(x.^2))fails.The error results from a call to
broadcastableon the arguments of(x.^2).value.term.E.g., the first argument is a
Term{Any}withRefas operation and^as its sole argument.I have added a
broadcastablefor anySymbolicthat catches this case and falls back to unspecializedbroadcastableotherwise.Because of the discussion in #409 I am not certain whether this solution is clever.
It's also the reason for the separate pull request.