Change the LuxCore extension to Lux to support recursively_nillify
#1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1266 +/- ##
===========================================
+ Coverage 8.30% 80.31% +72.00%
===========================================
Files 46 47 +1
Lines 4549 4634 +85
===========================================
+ Hits 378 3722 +3344
+ Misses 4171 912 -3259 ☔ View full report in Codecov by Sentry. |
SebastianM-C
changed the title
recursively_nillifyLuxCore extension to Lux to support recursively_nillify
ChrisRackauckas
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support the new
LuxCore.outputsize, we needNilSizePropagation.recursively_nillify(x)to work, but that's defined onAbstractArray{<:Real}.The problem is that vector variables are unwrapped to a
SymbolicUtils.BasicSymbolic{Vector{Real}}, which is not anAbstractArray. See SciML/ModelingToolkitNeuralNets.jl#39 (comment)I'm not sure if we need any other dispatch besides this. Also, I'm not sure if changing the extension like this can cause any issues for users that update the package. I can test this some more.