Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I exclude kwarg methods from test_ambiguities #227

Closed
fingolfin opened this issue Oct 31, 2023 · 2 comments
Closed

How can I exclude kwarg methods from test_ambiguities #227

fingolfin opened this issue Oct 31, 2023 · 2 comments

Comments

@fingolfin
Copy link
Collaborator

I just did

using Aqua, Nemo
Aqua.test_ambiguities(Nemo; exclude=[rand, divexact, ==, *, +, -, evaluate])

but this still reported e.g. this:

Ambiguity #1
kwcall(::Any, ::typeof(AbstractAlgebra.divexact), a::T, b::AbstractAlgebra.FracElem{T}) where T<:RingElem @ AbstractAlgebra ~/.julia/packages/AbstractAlgebra/dsta0/src/Fraction.jl:605
kwcall(::Any, ::typeof(AbstractAlgebra.divexact), a::Nemo.ZZRingElem, b::AbstractAlgebra.FracElem) @ Nemo ~/Projekte/OSCAR/Nemo.jl/src/flint/adhoc.jl:496

Possible fix, define
  kwcall(::Any, ::typeof(AbstractAlgebra.divexact), ::T, ::AbstractAlgebra.FracElem{T}) where T<:Nemo.ZZRingElem

I already asked it to exclude divexact, but that doesn't work here because it is a kwcall.

How can I get it to exclude this kind of method?

Actually to me ideally excluding divexact already would have excluded those, but I can live with having to specify yet another exclusion, I just don't know how to do it for those above

@lgoettgens
Copy link
Collaborator

Duplicate of #79

There is already #204 fixing exactly this, that is merely waiting for review.

@lgoettgens lgoettgens closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
@fingolfin
Copy link
Collaborator Author

Sorry -- I did search for existing issues, but stupidly only for "kwarg" :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants