Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circumvent pipe buffer deadlock #166

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Circumvent pipe buffer deadlock #166

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc2176e
Circumvent pipe buffer deadlock
lgoettgens Aug 24, 2023
20f5a86
Update src/ambiguities.jl
lgoettgens Aug 24, 2023
15aef7e
Update src/ambiguities.jl
lgoettgens Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/ambiguities.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,13 +126,11 @@ function _find_ambiguities(
end
cmd = `$cmd --startup-file=no -e $code`

out = Pipe()
err = Pipe()
outfile, out = mktemp(; cleanup = false)
lgoettgens marked this conversation as resolved.
Show resolved Hide resolved
errfile, err = mktemp(; cleanup = false)
lgoettgens marked this conversation as resolved.
Show resolved Hide resolved
succ = success(pipeline(cmd; stdout = out, stderr = err))
close(out.in)
close(err.in)
strout = String(read(out))
strerr = String(read(err))
strout = read(outfile, String)
strerr = read(errfile, String)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rm(outfile) and rm(errfile)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok we can also just leave it as is, fine by me.

num_ambiguities = if succ
0
else
Expand Down
Loading