Refactor test_deps_compat
#193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
force-pushed
the
lg/refactor-deps-compat
branch
from
8714834
to
f679bdb
Compare
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
==========================================
- Coverage 77.91% 76.80% -1.11%
==========================================
Files 11 11
Lines 756 763 +7
==========================================
- Hits 589 586 -3
- Misses 167 177 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fingolfin
approved these changes
Sep 25, 2023
lgoettgens
commented
Sep 25, 2023
lgoettgens
commented
Sep 25, 2023
lgoettgens
commented
Sep 25, 2023
lgoettgens
commented
Sep 25, 2023
lgoettgens
commented
Sep 25, 2023
Co-authored-by: Max Horn <max@quendi.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for fixing #178.
Changes existing functions to return intermediate results instead of
LazyTestResults. This enables better composability without repeating too much work. Furthermore, the internal tests got clearer and more readable.