Enhance test_ambiguities' exclude options for functions with kwargs
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
+ Coverage 87.94% 88.33% +0.39%
==========================================
Files 10 10
Lines 506 506
==========================================
+ Hits 445 447 +2
+ Misses 61 59 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lgoettgens
force-pushed
the
lg/kwarg-ambiguities
branch
from
8cc406f
to
299cb35
Compare
lgoettgens
force-pushed
the
lg/kwarg-ambiguities
branch
4 times, most recently
from
d5e4efd
to
d8997ff
Compare
Merged
lgoettgens
force-pushed
the
lg/kwarg-ambiguities
branch
from
d8997ff
to
487b4b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #79.
After this change, excluding some
fooadditionally excludes all instances ofCore.kwfunc(foo)that belong tofoo(i.e. the third parameter of the signature istypeof(foo).