Remove test_project_toml_formatting #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
==========================================
- Coverage 89.16% 87.94% -1.23%
==========================================
Files 11 10 -1
Lines 563 506 -57
==========================================
- Hits 502 445 -57
Misses 61 61
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lgoettgens
force-pushed
the
mh/kill-project_toml_formatting-test
branch
from
37c4cbb
to
ce3cd5d
Compare
lgoettgens
force-pushed
the
mh/kill-project_toml_formatting-test
branch
from
42c648a
to
5cb0d2d
Compare
It stands out from all other tests in Aqua in that it does not actually deal with 'quality'. The benefit is tiny if there is one at all, at the same time it is unreasonably compicated to implement and use right.
lgoettgens
approved these changes
Oct 24, 2023
|
@fingolfin I found some more code that is no longer needed. Could you have a look? (99bfddb) |
|
@lgoettgens thank you, makes sense, and Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It stands out from all other tests in Aqua in that it does not actually deal with 'quality'. The benefit is tiny if there is one at all, at the same time it is unreasonably compicated to implement and use right.
Resolves #208
Closes #206, closes #210