Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict project_toml_formatting to julia 1.7 and later #210

Closed
wants to merge 1 commit into from

Conversation

lgoettgens
Copy link
Collaborator

Resolves #208
Closes #206, closes #209.

Just make the test_toml_formatting a no-op on julia 1.6 and before.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #210 (2991b81) into master (19a5588) will decrease coverage by 12.83%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master     #210       +/-   ##
===========================================
- Coverage   76.80%   63.97%   -12.83%     
===========================================
  Files          11       11               
  Lines         763      583      -180     
===========================================
- Hits          586      373      -213     
- Misses        177      210       +33     
Flag Coverage Δ
unittests 63.97% <0.00%> (-12.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/project_toml_formatting.jl 17.85% <0.00%> (-67.86%) ⬇️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't mean to approve right away: the code changes are good but could you add tests, like the ones i tried to whip up in #206?

@lgoettgens
Copy link
Collaborator Author

lgoettgens commented Oct 15, 2023

Sorry I didn't mean to approve right away: the code changes are good but could you add tests, like the ones i tried to whip up in #206?

I would do that once the decision between this and #209 is made. I'll try to talk to @fingolfin this week about it.

@lgoettgens lgoettgens deleted the lg/formatting-1.7 branch December 1, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project.toml formatting test not sensible in julia pre-1.7
2 participants