-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove special handling of stdlibs in test_deps_compat
#215
Conversation
04272c6
to
4287ebf
Compare
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 89.63% 88.71% -0.93%
==========================================
Files 10 10
Lines 415 505 +90
==========================================
+ Hits 372 448 +76
- Misses 43 57 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4287ebf
to
ac007e1
Compare
ac007e1
to
b662e48
Compare
477cdbd
to
40176e2
Compare
This (or something surrounding it) seems to have caused quite a few failures in PkgEval, which reduces the overall testing coverage in the ecosystem. Is there something we can do about this? For example: Looking at the apparent red cliff in the report: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/1fc9d54_vs_72cd63c/report.html Some don't seem precisely related, as the error appears to complain about packages (e.g. BenchmarkTools) that don't appear to even be installed in the log? |
Yes, parts of the failures you linked are due to this change. But a lot are due to checking extras and weakdeps in general since #202. So every package declaring Aqua as a extra-Dep without a compat bound will fail as well. The clean solution would be to change all failing packages to either fix the issues there or (easier) add a compat entry for Aqua 0.7 there. |
Resolves #212.