Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error when [extras] and test/Project.toml inconsistent #234

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

fingolfin
Copy link
Collaborator

It is very easy to miss that this error only occurs because of a
missing compat entry for Julia...

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #234 (4da9c64) into master (3ea2897) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   76.17%   76.17%           
=======================================
  Files          11       11           
  Lines         768      768           
=======================================
  Hits          585      585           
  Misses        183      183           
Flag Coverage Δ
unittests 76.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/project_extras.jl 98.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@lgoettgens
Copy link
Collaborator

Could you please make the formatter job happy and add a one-liners to the changelog? Then this is good to go from my POV

@lgoettgens lgoettgens added this to the 0.8 milestone Nov 5, 2023
It is very easy to miss that this error only occurs because of a
missing compat entry for Julia...
@lgoettgens lgoettgens merged commit b943093 into JuliaTesting:master Nov 6, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants