Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require [compat] entry for julia #236

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

lgoettgens
Copy link
Collaborator

Resolves #235.

As this is point 7 in the guidelines for the General registry, I support Aqua checking this.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #236 (cdede79) into master (3ea2897) will decrease coverage by 2.08%.
Report is 1 commits behind head on master.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   76.17%   74.09%   -2.08%     
==========================================
  Files          11       11              
  Lines         768      776       +8     
==========================================
- Hits          585      575      -10     
- Misses        183      201      +18     
Flag Coverage Δ
unittests 74.09% <89.47%> (-2.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/project_extras.jl 98.00% <100.00%> (ø)
src/deps_compat.jl 73.07% <88.88%> (+2.80%) ⬆️

... and 6 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@lgoettgens lgoettgens requested review from fingolfin and removed request for fingolfin November 6, 2023 16:39
@lgoettgens lgoettgens marked this pull request as ready for review November 6, 2023 16:39
@lgoettgens lgoettgens added this to the 0.8 milestone Nov 6, 2023
@lgoettgens
Copy link
Collaborator Author

@fingolfin Do you wanna have a look at this? If not, I will just merge this and #223, and then release 0.8.0.

@lgoettgens lgoettgens mentioned this pull request Nov 13, 2023
Copy link
Contributor

@hyrodium hyrodium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor comment. Other changes LGTM.

src/deps_compat.jl Show resolved Hide resolved
@lgoettgens lgoettgens merged commit 1b133dd into JuliaTesting:master Nov 15, 2023
21 of 23 checks passed
@lgoettgens lgoettgens deleted the lg/compat-julia branch November 15, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require Julia compat bound
2 participants