Refactor LazyTestResult away
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #237 +/- ##
==========================================
- Coverage 76.33% 75.33% -1.01%
==========================================
Files 11 11
Lines 786 750 -36
==========================================
- Hits 600 565 -35
+ Misses 186 185 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lgoettgens
force-pushed
the
lg/refactor
branch
3 times, most recently
from
2f1d39b
to
0e93f09
Compare
lgoettgens
changed the title
LazyTestResult awayLazyTestResult away
lgoettgens
force-pushed
the
lg/refactor
branch
from
beaafdc
to
c5d96ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards #180 as it gets rid of
LazyTestResult, which is inherently incompatible with returning a list of things. Furthermore, it makes the code more readable without it.And some more minor cleanup.