Fix environments in test_persistent_tasks
#240
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 76.24% 76.27% +0.03%
==========================================
Files 11 11
Lines 783 784 +1
==========================================
+ Hits 597 598 +1
Misses 186 186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -152,7 +152,8 @@ end | |||
| end | |||
| # Precompile the wrapper package | |||
| cmd = `$(Base.julia_cmd()) --project=$wrapperdir -e 'using Pkg; Pkg.precompile()'` | |||
| proc = run(cmd; wait = false) | |||
| cmd = setenv(cmd, String[]) | |||
There was a problem hiding this comment.
This clears all environment variables for the subprocess, among other PATH and Polymake.jl for example relies on that being non-empty (which is imho a reasonable assumption). Also it might break running any other shell commands from the package initialization.
See for example here: https://github.com/oscar-system/Polymake.jl/actions/runs/6891113309/job/18747915661?pr=461#step:7:478
ERROR: LoadError: InitError: KeyError: key "PATH" not found
Stacktrace:
[1] (::Base.var"#717#718")(k::String)
@ Base ./env.jl:138
[2] access_env
@ Base ./env.jl:43 [inlined]
[3] getindex
@ Base ./env.jl:138 [inlined]
[4] __init__()
@ Polymake ~/work/Polymake.jl/Polymake.jl/src/Polymake.jl:187
There was a problem hiding this comment.
Ahh, what a bummer...
I'll test around with Polymake.jl then a try to get a 0.8.2 running that's fine with both Polymake.jl and AbstractAlgebra.jl.
On the CI testing setup of AbstractAlgebra.jl, I got the following error in the sub-process of
test_persistent_tasks. (log)After some digging around, I found that
LOAD_PATHwas just["@", "/tmp/jl_yzJAOE"]there, so that's the reason whyPkgcould not be found. The easiest (and only) solution I could find, was to clear the ENV of the sub-process explicitly to allow a default value forLOAD_PATHto populate (see https://docs.julialang.org/en/v1/manual/environment-variables/#JULIA_LOAD_PATH).Furthermore, this PR allows errors in the sub-process to show up in the stderr of the main process.