Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environments in test_persistent_tasks (part 2) #241

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

lgoettgens
Copy link
Collaborator

@lgoettgens lgoettgens commented Nov 16, 2023

Circumvents the problem found by @benlorenz in #240 (comment).

@lgoettgens lgoettgens added bug Something isn't working test: persistent tasks labels Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fb04b7) 76.27% compared to head (185d797) 76.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
- Coverage   76.27%   76.24%   -0.04%     
==========================================
  Files          11       11              
  Lines         784      783       -1     
==========================================
- Hits          598      597       -1     
  Misses        186      186              
Flag Coverage Δ
unittests 76.24% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens merged commit 1d6cf6f into JuliaTesting:master Nov 16, 2023
25 checks passed
@lgoettgens lgoettgens deleted the lg/env2 branch November 16, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test: persistent tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant