-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand and clarify docs on persistent tasks #297
Conversation
Without Aqua's tests, the developers of `PkgA` might not realize that their | ||
package is essentially unusable with any other package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ I love it. Thank you!
Thanks for the PR. If you and @NHDaly are happy with the changes, there is no further action required from your side. I'll go ahead with updating the changelog and preparing a release with this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #297 +/- ##
==========================================
+ Coverage 74.77% 74.90% +0.13%
==========================================
Files 11 11
Lines 761 761
==========================================
+ Hits 569 570 +1
+ Misses 192 191 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for the review and for merging it! And of course especially for your ongoing maintenance, @lgoettgens, of this crucial package! |
While helping someone on slack I noticed these docs were a bit less clear than they could be. Here's my attempt at improving them. CC @NHDaly.