Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand and clarify docs on persistent tasks #297

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

timholy
Copy link
Contributor

@timholy timholy commented Oct 4, 2024

While helping someone on slack I noticed these docs were a bit less clear than they could be. Here's my attempt at improving them. CC @NHDaly.

Comment on lines +46 to +47
Without Aqua's tests, the developers of `PkgA` might not realize that their
package is essentially unusable with any other package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ I love it. Thank you!

@lgoettgens
Copy link
Collaborator

Thanks for the PR. If you and @NHDaly are happy with the changes, there is no further action required from your side. I'll go ahead with updating the changelog and preparing a release with this.
If this PR is still open in a few days, I might have forgotten it. Feel free to ping me then.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.90%. Comparing base (3499e74) to head (8abc65f).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
+ Coverage   74.77%   74.90%   +0.13%     
==========================================
  Files          11       11              
  Lines         761      761              
==========================================
+ Hits          569      570       +1     
+ Misses        192      191       -1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens merged commit 065f7d7 into JuliaTesting:master Oct 10, 2024
24 checks passed
@timholy timholy deleted the teh/more_task_docs branch October 11, 2024 18:13
@timholy
Copy link
Contributor Author

timholy commented Oct 11, 2024

Thanks for the review and for merging it! And of course especially for your ongoing maintenance, @lgoettgens, of this crucial package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants