Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify intention behind failing tests #48

Open
danielsoutar opened this issue Feb 20, 2022 · 1 comment
Open

Clarify intention behind failing tests #48

danielsoutar opened this issue Feb 20, 2022 · 1 comment

Comments

@danielsoutar
Copy link

If a developer were to run the tests for ReTest.jl, they would observe a number of tests failing, such as those found in Main.FailingLoops. While there is a good reason for having failing tests in ReTest.jl, namely checking the library behaves as expected when the tests fail, it is confusing/misleading for the developer, especially newcomers.

It would be good to indicate which tests are expected to fail. This would be most easily achieved by moving the failing tests into a dedicated file and includeing it into the main runtests.jl file. Alternatively, we could potentially mark these with test_broken, although the Julia docs state that this macro is for indicating "a test that should pass".

@rfourquet
Copy link
Collaborator

Yes this is a good point. Isn't it ironic that the test suite for ReTest looks so bad ;-)
I've definitely focused on improving ReTest itself rather than having its own tests look nice, but it would definitely be great to improve on that front too. This isn't a priority though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants