-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds timestamps to the log format #11
Conversation
Is there any problem with the pull request? |
Is it really necessary to make this a per-module configuration, instead of having it global like I also have style changes to make to the added documentation, I'll push them directly as a commit to this PR once we agree on making this global or module-specific. |
Here's my proposal to simplify the API and improve the docs and formatting: akien-mga@3dfd241 If you're OK with the changes I'll squash the two commits and push to update this PR and merge. |
Also, did you follow any specific standard for the timestamp placeholders? Going by https://en.wikipedia.org/wiki/ISO_8601 (which seems to match Unix timestamp), these would be better:
|
New commit: https://github.com/akien-mga/godot-logger/tree/SirMom-feature/log-timestamp Edit: Updated after actually testing my changes and finding some issues. |
I did that because I thought the purpose of the modules is the configuration of the log message and thus I put in the Module. |
No I did not follow any standard but had this in mind. Yes following this is a way better approach! |
Modules are not specifically for configuration, but to have different channels for different types of log messages. E.g. in a networked game you could have a "Server" module and a "Client" module, etc. I'm not against making configuration module-specific, but that adds configuration overhead every time you create new modules (and this would require making |
Timestamps follow ISO 8601. Fix some pre-existing bogus docs. Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
85fc770
to
e2723d8
Compare
Thanks! |
Add timestamps to be used in the log format.
And updates the README.md to reflect the changes and give more insight to the formatting options.
Example:
Results in:
I mentioned a timestamp system in #9