Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/id18 #21

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions amd/build/issue_view.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@



class IssueView {
constructor() {
const commentandcommitbtn = $("button[name=closeissue]");
const comment = $("#commenteditoreditable").children("p");
comment.onchange(event => {
console.log('comment has changed')
if (event.target.value == "") {
commentandcommitbtn.text = closeissuestring;
} else {
commentandcommitbtn.text = commentandcloseissuestring;
}
})
}

}
2 changes: 2 additions & 0 deletions amd/build/issue_view.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions amd/build/issue_view.min.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 42 additions & 0 deletions amd/src/issue_view.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.

/**
* Manager for managing question issues.
*
* @module local_qtracker/IssueView
* @class IssueView
* @package local_qtracker
* @author David Rise Knotten <david_knotten@hotmail.no>
* @copyright 2021 NTNU
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
import $ from 'jquery';

class IssueView {
constructor(closeissuestring, commentandcloseissuestring) {
const commentandcommitbtn = $("button[name=closeissue]").get(0);
const commentEditor = $("#commenteditor").get(0);
commentEditor.addEventListener("change", event => {
if (commentEditor.value == ('<p dir="ltr" style="text-align: left;"><br></p>')) {
commentandcommitbtn.innerText = closeissuestring;
} else {
commentandcommitbtn.innerText = commentandcloseissuestring;
}
})
}
}

export default IssueView;
3 changes: 2 additions & 1 deletion lang/en/local_qtracker.php
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@
$string['allissues'] = 'All issues';

$string['reopenissue'] = 'Reopen issue';
$string['closeissue'] = 'Comment and close issue';
$string['closeissue'] = 'Close issue';
$string['commentandcloseissue'] = 'Comment and close issue';
$string['comment'] = 'Comment';

//TODO clean up the text
Expand Down