Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No validation for the number of stars required for passing grade #172

Open
nicolopinci opened this issue Dec 24, 2019 · 1 comment
Open
Labels
bug Something isn't working

Comments

@nicolopinci
Copy link

Describe the bug
It is possible to set any number of stars required for passing grade.

To Reproduce
Go in the grading tab for a CAPQUIZ topic and try to set the number of required stars to a value greater than 5.

Expected behavior
The number should be limited in the range 0 to 5.

@nicolopinci nicolopinci added the bug Something isn't working label Dec 24, 2019
@andstor
Copy link
Member

andstor commented Dec 24, 2019

I can confirm that it is indeed possible to set the Number of stars required for passing grade to a number higher than the number of stars defined within the activity.

A restriction should be added to limit the Number of stars required for passing grade to be lower than or equal to the number of stars defined in the activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants