Check errors form workflows

[hgeorgsch]

No description provided.

[hgeorgsch]

The Moodle Code Checker has been satisfied.
Many remaining problems seem to concern dummy callback functions, and although the warning can easily be fixed, there is an underlying problem of lacking error handling, which is not easily fixed.

[hgeorgsch]

New errors are reported by the Code Checker.
The total number of errors is such that the work to fix them all would be tedious and demotivating.

[hgeorgsch]

All workflows needs updating, using Moodle 4.x.

[jorgenfinsveen]

Looking into this now. All of the tasks got dropped immediately and I got a warning about the Ubuntu version used in the workflow was deprecated and should be changed. Have done this and at least now all tasks are actually started before they all fail.

@hgeorgsch just an idea, but should we alter the prerequisites for task failure? E.g. the Moodle Code Checker task fails due to a warning-tolerance of 0, making the whole task fail due to e.g. an unecessary whitespace at the end of a line. Doesn't this seem a bit strict to fail the whole task if all it takes is a single warning?

[jorgenfinsveen]

Moodle Code Checker has now 0 errors but still a couple of warnings such as this:

 FILE: /home/runner/work/moodle-mod_jazzquiz/moodle-mod_jazzquiz/moodle/mod/jazzquiz/backup/moodle2/restore_jazzquiz_stepslib.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 17 | WARNING | Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
    |         | (moodle.Files.MoodleInternal.MoodleInternalNotNeeded)

Because of this, the task still fails since the workflow-file specifies that there cannot be any warnings. Is this necessary?

[jorgenfinsveen]

Grunt task detects no longer any errors, but it still fails due to some warnings and due to the problem with the css mentioned in #67.

[jorgenfinsveen]

Mustache task fails due to warnings related to documentation. It will not go through until all .mustache files contain a example context such as this:

[jorgenfinsveen]

The Convert Coverage and the Coveralls Parallel tasks both fails due to missing src files. I assume that the src files is generated when running .travis.yml, but I am not sure how this could be fixed.

[hgeorgsch]

Generally, we want to heed warnings, so it is definitely best if we can make the code fully compliant.
OTOH, at the moment we are overwhelmed, so if you can fix the errors, it may be a good idea to change the settings to allow warnings.

If you do turn of warnings, please make a new issue, tagged as can wait or even wont fix, with an explanation of how to turn the warning back on. Main reason for this is to give me a way to remember how to turn warnings back on.

[jorgenfinsveen]

@hgeorgsch created an issue as you described here #119. Turned off the zero-warning tolerance in the workflow file. Workflow still fails on the CSS mentioned in #67, but that part should be all good when the pull request is approved and merged into main.

The Convert Coverage and Coveralls Parallel tasks are still failing, and I do not know enough about it to say how they can be fixed. Mustache Lint only fails on some of the tests due to the lack of documentation of the mustache-files.

Opens a pull request on the changes made so far. Leaves it open for others with more knowledge of the last failing tasks to come with some ideas on how to fix them.

[jorgenfinsveen]

To finally complete this issue, the following needs to be done:

• Convert Coverage and Coneralls Parallel needs to be fixed. They don't work due to a non-existing target file. I suspect that the missing file is something which is autogenerated when running the Convert Coverage task.
• CSS !important keywords must be removed. This will be in order when removed outdated CSS #116 is merged.
• Mustache files must have documentation specifying its template name as well as an example context as shown here.

[andstor]

Hi 👋 @jorgenfinsveen I can probably take a look at the Coverage file problem after I get back from vacation in a couple of weeks.

[hgeorgsch]

See #122 and #121