Add common DragCubeTool, now with caching #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
al2me6
requested changes
Sep 1, 2024
Source/ROUtils/Utils/DragCubeTool.cs
Outdated
|
|
||
| if (_cacheDict.Count > MaxCacheSize) | ||
| { | ||
| Debug.Log($"[DragCubeTool] Cache limit reached ({_cacheDict.Count} / {MaxCacheSize}), emptying..."); |
There was a problem hiding this comment.
I guess there's no collection type that does LRU or something
Source/ROUtils/Utils/DragCubeTool.cs
Outdated
|
|
||
| private static bool VectorsNearlyEqual(Vector3 v1, Vector3 v2) | ||
| { | ||
| return (v1 - v2).sqrMagnitude < 2.5E-5f; |
siimav
force-pushed
the
MyGodItsFullOfDragCubes
branch
3 times, most recently
from
82183fb
to
380a952
Compare
siimav
force-pushed
the
MyGodItsFullOfDragCubes
branch
5 times, most recently
from
a93b676
to
3e6da24
Compare
siimav
force-pushed
the
MyGodItsFullOfDragCubes
branch
from
3e6da24
to
0fdcab3
Compare
al2me6
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering the same drag cube for the 10th time isn't a particularly good use of resources.