Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eye-piercing red texts in contract details and crewed earth orbit contract descriptions #2062

Merged
merged 17 commits into from
Jul 12, 2023

Conversation

byt3c
Copy link
Contributor

@byt3c byt3c commented Jun 24, 2023

Fix description in contract to enable triggering success criteria.

@TwistedGiraffe
Copy link
Contributor

Instead of explicitly requiring a part, how about requiring the science a la #1942?

@byt3c
Copy link
Contributor Author

byt3c commented Jun 24, 2023

it might be a nice twist to get people to place actual sensor on a craft :) i have nothing against requiring a device present as long as it is in the description. It gives a slight challenge to place items correctly :)

@siimav
Copy link
Contributor

siimav commented Jun 25, 2023

Looks like you added some unrelated changes to this PR now.

@byt3c
Copy link
Contributor Author

byt3c commented Jun 26, 2023

welp - i think i pushed manned orbit contract description fix to the same branch. Now there are two fixes :)

@byt3c byt3c changed the title fix first lunar orbiter contract description fix first lunar orbiter and crewed earth orbit contract descriptions Jun 26, 2023
@byt3c byt3c changed the title fix first lunar orbiter and crewed earth orbit contract descriptions fix eye-piercing red texts in contract details and crewed earth orbit contract descriptions Jul 8, 2023
@siimav
Copy link
Contributor

siimav commented Jul 8, 2023

Probably not the best wording on those two crewed orbital flight contracts. @NovemberOrWhatever thoughts?

@NovemberOrWhatever
Copy link
Contributor

Once you've completed this contract, Orbital Flight (One Crew) contracts will become unavailable. If you have both this and the Orbital Flight (One Crew) contract accepted, completing this will cause that contract to fail.

Is there any penalty for failing though? Or was it just decline that we changed?

@siimav
Copy link
Contributor

siimav commented Jul 8, 2023

Is there any penalty for failing though? Or was it just decline that we changed?

Nope, both are 0 now.

@byt3c
Copy link
Contributor Author

byt3c commented Jul 8, 2023

I received a lot of negative rep (like failing contract not cancelling it) when reporting - not sure how it is now.

byt3c and others added 2 commits July 8, 2023 20:34
using  November's text instead of initial commit.
@Capkirk123 Capkirk123 merged commit 7acec05 into KSP-RO:master Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants