Allow encoders to be manually defined by ground stations #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
siimav
requested changes
Aug 29, 2024
Comment on lines
34
to
37
| public static Encoder Get(string name, int level) | ||
| { | ||
| return string.IsNullOrEmpty(name) || !All.TryGetValue(name, out Encoder encoder) ? Encoder.GetFromTechLevel(level) : encoder; | ||
| } |
There was a problem hiding this comment.
TBH I would write this as GetByName and then in calling code use GetByName(overrride) ?? GetFromTechLevel(level).
There was a problem hiding this comment.
Alright rewrote it so the discrimination is done when the function is called.
| @@ -27,8 +27,9 @@ public class RealAntenna | |||
| public virtual double Bandwidth => DataRate; // RF bandwidth required. | |||
| public virtual float AMWTemp { get; set; } | |||
| public virtual float Beamwidth => Physics.Beamwidth(Gain); | |||
| public string encoderOverride { get; set; } | |||
There was a problem hiding this comment.
You should match case with the rest of the code. Also I spot an extra whitespace.
There was a problem hiding this comment.
I tried to match the formatting (although I have no idea what virtual means, it still works fine) and I think I removed the whitespace in question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow encoders to be manually selected by name for ground stations. This will allow Skopos ground stations to select historically accurate encoders rather than being forced to use the default encoders included with RealAntennas.