Fixes for issue #206 (BetterUndoRedo) #210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to move calls to
EditorLogic.SetBackup()
before the actions take place (instead of after), see issue #206The backup is created from callbacks called from the gizmo components
OnMoveEnd
/OnRotateEnd
methods, triggered when the gizmo is released. The gizmos do have aOn*Start
method, but unfortunately they aren't hooked to a callback, and those are generic components that can potentially be used elsewhere. We can still patch those methods, and compare the gizmo instance to theEditorLogic.gizmo*
fields.Requires moving theSetBackup()
call at the beginning of theModulePartVariants.onVariantChanged
methodDoesn't work because the field is already set when
ModulePartVariants.onVariantChanged
, so the changes will be saved to the backup anyway. Alternatively, we patchUIPartActionVariantSelector.SelectVariant()
Requires moving the
SetBackup()
call at the beginning of thePart.RemoveFromSymmetry
methodRequires moving the
SetBackup()
call at the beginning of theEditorActionGroups
ResetPart
,AddActionToGroup
andRemoveActionFromGroup
methodsRequires moving theSetBackup()
call at the beginning of theStageManager.Reset
methodActually after further testing, it seems the backup is already created before the action, so nothing to fix here