Update to 0.2.11 from 'dev' branch

KSneijders · Nov 2, 2024 · 7521b5b · 7521b5b
2 parents f21e8c9 + 7141dcf
commit 7521b5b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/AoE2ScenarioParser/objects/data_objects/effect.py b/AoE2ScenarioParser/objects/data_objects/effect.py
@@ -193,12 +193,12 @@ def __init__(
             # If created through new_effect with quantity defined instead of the aa values. Handled by quantity property
             else:
                 pass
-        elif variable is None and _variable_ref is not None:
-            # If effect created through reading scenario file and is a normal effect, just set the normal attribute
-            variable = _variable_ref
         else:
             armour_attack_class = armour_attack_quantity = None
 
+        if variable is None:
+            variable = _variable_ref if _variable_ref is not None else -1
+
         area_x1, area_y1, area_x2, area_y2 = validate_coords(area_x1, area_y1, area_x2, area_y2)
 
         if value_is_valid(legacy_location_object_reference):

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
+## 0.2.11 - 2024-November-02
+
+### Fixed
+
+- Fixed the same bug corrupting scenarios - missed even more edge cases...
+
+---
+
 ## 0.2.10 - 2024-November-02
 
 ### Fixed