Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

Ref values break the generation of cloudformation #118

Open
wenisman opened this issue Sep 27, 2018 · 2 comments
Open

Ref values break the generation of cloudformation #118

wenisman opened this issue Sep 27, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@wenisman
Copy link

Describe the bug
Currently basic support for !Ref isnt working. Whilst trying to parse in a single parameter the compiled output will have no Resources

To Reproduce
Steps to reproduce the behavior:

  1. create a basic vpc.yaml
AWSTemplateFormatVersion: 2010-09-09
Description: The base VPC
Parameters:
  CidrBlock:
    Description: The range of IPs for the VPC
    Type: String
Resources:
  Vpc:
    Type: AWS::EC2::VPC
    Properties:
      CidrBlock: !Ref CidrBlock
  1. Run Generate
> kombustion upsert  --param CidrBlock=10.0.0.0/16 stacks/vpc.yaml

Current behaviour:

AWSTemplateFormatVersion: "2010-09-09"
Description: The base VPC for the ECS cluster
Parameters:
  CidrBlock:
    Description: The range of IPs for the VPC
    Type: String
Resources: {}

Expected behavior
A basic cloudformation with the reference value populated should be created.

Screenshots
NA

Desktop (please complete the following information):

  • macOS High Sierra
  • Version 0.3.6
@wenisman wenisman changed the title Ref vales are not replaced Ref values break the generation of cloudformation Sep 27, 2018
@ojkelly
Copy link
Contributor

ojkelly commented Sep 27, 2018

Hey @wenisman,

Thanks for the detailed report. This sounds like it might be related to #113, which nearly has a fix. I'll try and reproduce after that fix is merged.

@ojkelly ojkelly added the bug Something isn't working label Sep 27, 2018
@wenisman
Copy link
Author

Thanks @ojkelly
ill have a read through the code and see whats happening.
#113 looks like it has to do with incorrect outputs being generated. I got around that by just disabling default outputs. I was getting both subnet and vpc failures when i had default outputs enabled

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants