Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete implicit in dockerfile #1288

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Delete implicit in dockerfile #1288

merged 5 commits into from
Aug 14, 2023

Conversation

psbang
Copy link
Contributor

@psbang psbang commented Aug 11, 2023

@psbang psbang requested a review from djherbis August 11, 2023 14:28
@psbang psbang changed the title Use pip instead of mamba Delete implicit in dockerfile Aug 11, 2023
@djherbis
Copy link
Contributor

It looks like our two PRs may be dependent on one another #1282

I'm going to merge both and see what happens.

@djherbis djherbis merged commit bbf8424 into main Aug 14, 2023
3 checks passed
@djherbis djherbis deleted the psbang-implicit branch August 14, 2023 13:42
@@ -172,7 +163,9 @@ RUN pip install spacy && \
{{ if eq .Accelerator "gpu" }}
# Install GPU-only packages
# No specific package for nnabla-ext-cuda 11.x minor versions.
RUN pip install pycuda \
RUN export PATH=/usr/local/cuda/bin:$PATH && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djherbis @psbang Any reasons why you updated the PATH and CUDA_ROOT? Also, a comment would be helpful to explain to future readers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read it as a solution in a stackoverflow somewhere, I'll make sure to add the links in next time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A solution for what? You are removing the package in the end no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting "Failed building wheel for pycude" errors, I found a solution here: https://forums.developer.nvidia.com/t/cant-install-pycuda/238230

RUN rm /opt/conda/bin/../lib/libcusolver.so.11 && ln -s /usr/local/cuda/lib64/libcusolver.so.11 /opt/conda/bin/../lib/libcusolver.so.11
{{ else }}
RUN ln -s /usr/local/cuda/lib64/libcusolver.so.11 /opt/conda/bin/../lib/libcusolver.so.11
Copy link
Contributor

@rosbo rosbo Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psbang Same here, I am a bit surprised to see a cuda related command for non-gpu image build... A comment would be helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this one, the build was failing for CPU because the directory it was trying to delete did not exist, but for some reason, that directory did exist on the GPU build, so this was the only way I was able to make it build successfully.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you remember what process was trying to delete this directory? The underlying issue is likely that we were running a command that shouldn't have been run in the CPU and was missing the {{ if eq .Accelerator "gpu" }} guard.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 643 in the updated file, I didn't change that, I just added the if-else statements around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants