Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pkgdepends for package installation #80

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rvalieris
Copy link

Hello, this is a followup on #78.

I see that @calderjo managed to get the build working, thats awesome !! I couldn't figure out how to make make_dependency_list work so I went a different direction, utilizing pkgdepends to do the package installation, I'm submitting the PR anyway in case its useful.

main changes are:

  • sanitize the package list
    packages_users contains many entries that are obviously not packages such as empty string, single letters, and words that aren't packages such as "geom_text" (thats a function from ggplot2).
  • use pkgdepends for installation

besides not having to mess with make_dependency_list, it can install packages from both CRAN and Bioconductor, and it also handles installing missing system libraries if the package declares them, these are the dependencies pkgdepends installed, besides the libraries that are already being installed on the Dockerfile:

p$show_sysreqs() + cargo - gifski + default-jdk - Deducer, JavaGD, JGR, OpenStreetMap, openNLPdata, RWeka, RWekajars, XLConnect, arulesCBA, bartMachine, bartMachineJARs, coreNLP, dismo, glmulti, h2o, openNLP, venneuler, rCBA, rJava, rcdk, xlsx + gdal-bin - sf, terra, concaveman, mlr, warbleR + jags - MBNMAdose, R2jags, mlr, rjags, runjags + libavfilter-dev - av + libboost-all-dev - RQuantLib + libgl1-mesa-dev - rgl + libgmp3-dev - Rmpfr, arrangements, PMCMRplus, gmp, mlr + libmpfr-dev - Rmpfr, PMCMRplus, mlr + libopenmpi-dev - ergm, mlr + libprotoc-dev - protolite + libquantlib0-dev - RQuantLib + libxslt-dev - xslt + pandoc-citeproc - bayesplot, footBayes, loo, rstanarm + pari-gp - elliptic + rustc - gifski + tcl - rriskDistributions, tcltk2 + texlive - animation, huxtable, texreg + tk - rriskDistributions, tcltk2 + tk-dev - rriskDistributions, tcltk2 + tk-table - rriskDistributions, tcltk2

Copy link

google-cla bot commented Jun 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant