From 8b5ee639b46dc839bacf14668bb6160a87bdb762 Mon Sep 17 00:00:00 2001
From: Rahul Iyer <4255590+rahuliyer95@users.noreply.github.com>
Date: Wed, 28 Aug 2024 18:54:49 -0700
Subject: [PATCH] Add PySpark 3.4.0 docset (#5111)

* Add PySpark 3.4.0 docset

* Update default docset
---
 docsets/pyspark/README.md   | 10 ++++++----
 docsets/pyspark/docset.json | 16 ++++++++++++----
 2 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/docsets/pyspark/README.md b/docsets/pyspark/README.md
index a43ad9ff6c..11300e3aaa 100644
--- a/docsets/pyspark/README.md
+++ b/docsets/pyspark/README.md
@@ -1,10 +1,12 @@
 pyspark Docset
-=======================
+==============
 
+* Author: Rahul Iyer (https://twitter.com/rahuliyer95) - versions: 3.4.0
 * Author: Tomas Kunka (https://twitter.com/TomasKunka) - versions: 3.0.0, 2.4.0
 * Author: Ronert Obst (https://twitter.com/ronert_obst) - versions: 2.1.0, 1.6.1, 1.5.1
 * Instructions
   * Clone the Apache Spark repo
-  * Modify spark/python/docs/conf.py and add `html_theme_options = {"nosidebar": "true"}` under `html_theme = 'nature'`
-  * Run make html
-  * Then run doc2dash
\ No newline at end of file
+  * Modify `spark/python/docs/conf.py` and add `html_theme_options = {"nosidebar": "true"}` under `html_theme = 'nature'`
+  * Run `make html`
+    * Optionally `export SPHINXOPTS="-j auto --keep-going"`
+  * Then run doc2dash
diff --git a/docsets/pyspark/docset.json b/docsets/pyspark/docset.json
index f38dbb276b..7fd697c610 100644
--- a/docsets/pyspark/docset.json
+++ b/docsets/pyspark/docset.json
@@ -1,10 +1,10 @@
 {
     "name": "pyspark",
-    "version": "3.0.0",
+    "version": "3.4.0",
     "archive": "pyspark.tgz",
     "author": {
-        "name": "Tomas Kunka",
-        "link": "https://twitter.com/TomasKunka"
+        "name": "Rahul Iyer",
+        "link": "https://twitter.com/rahuliyer95"
     },
     "aliases": [
         "Spark",
@@ -12,6 +12,14 @@
         "GraphX"
     ],
     "specific_versions": [
+        {
+            "author": {
+                "name": "Rahul Iyer",
+                "link": "https://twitter.com/rahuliyer95"
+            },
+            "version": "3.4.0",
+            "archive": "versions/3.4.0/pyspark.tgz"
+        },
         {
             "author": {
                 "name": "Tomas Kunka",
@@ -45,4 +53,4 @@
             "archive": "versions/1.5.1/pyspark.tgz"
         }
     ]
-}
\ No newline at end of file
+}