Skip to content

Commit

Permalink
Merge pull request kubernetes-sigs#10906 from cahillsf/reenable-mhc-u…
Browse files Browse the repository at this point in the history
…nit-test

🌱 Reenable 2 MHC unit tests
  • Loading branch information
k8s-ci-robot authored Jul 29, 2024
2 parents 9c08773 + 5050e3c commit ff2f73f
Showing 1 changed file with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -876,13 +876,11 @@ func TestMachineHealthCheck_Reconcile(t *testing.T) {
})

t.Run("when a Machine has no Node ref for longer than the NodeStartupTimeout", func(t *testing.T) {
// FIXME: Resolve flaky/failing test
t.Skip("skipping until made stable")
g := NewWithT(t)
cluster := createCluster(g, ns.Name)

mhc := newMachineHealthCheck(cluster.Namespace, cluster.Name)
mhc.Spec.NodeStartupTimeout = &metav1.Duration{Duration: time.Second}
mhc.Spec.NodeStartupTimeout = &metav1.Duration{Duration: 5 * time.Second}

g.Expect(env.Create(ctx, mhc)).To(Succeed())
defer func(do ...client.Object) {
Expand Down Expand Up @@ -976,12 +974,11 @@ func TestMachineHealthCheck_Reconcile(t *testing.T) {
})

t.Run("when a Machine's Node has gone away", func(t *testing.T) {
// FIXME: Resolve flaky/failing test
t.Skip("skipping until made stable")
g := NewWithT(t)
cluster := createCluster(g, ns.Name)

mhc := newMachineHealthCheck(cluster.Namespace, cluster.Name)
mhc.Spec.NodeStartupTimeout = &metav1.Duration{Duration: 5 * time.Second}

g.Expect(env.Create(ctx, mhc)).To(Succeed())
defer func(do ...client.Object) {
Expand Down

0 comments on commit ff2f73f

Please sign in to comment.