From 5050e3c39205f5a09e3a8929d200522c2309b53e Mon Sep 17 00:00:00 2001 From: Stephen Cahill Date: Thu, 18 Jul 2024 19:43:26 -0400 Subject: [PATCH] reeable MHC unit tests --- .../machinehealthcheck_controller_test.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/internal/controllers/machinehealthcheck/machinehealthcheck_controller_test.go b/internal/controllers/machinehealthcheck/machinehealthcheck_controller_test.go index 4645f43df91e..230e66e14eb5 100644 --- a/internal/controllers/machinehealthcheck/machinehealthcheck_controller_test.go +++ b/internal/controllers/machinehealthcheck/machinehealthcheck_controller_test.go @@ -876,13 +876,11 @@ func TestMachineHealthCheck_Reconcile(t *testing.T) { }) t.Run("when a Machine has no Node ref for longer than the NodeStartupTimeout", func(t *testing.T) { - // FIXME: Resolve flaky/failing test - t.Skip("skipping until made stable") g := NewWithT(t) cluster := createCluster(g, ns.Name) mhc := newMachineHealthCheck(cluster.Namespace, cluster.Name) - mhc.Spec.NodeStartupTimeout = &metav1.Duration{Duration: time.Second} + mhc.Spec.NodeStartupTimeout = &metav1.Duration{Duration: 5 * time.Second} g.Expect(env.Create(ctx, mhc)).To(Succeed()) defer func(do ...client.Object) { @@ -976,12 +974,11 @@ func TestMachineHealthCheck_Reconcile(t *testing.T) { }) t.Run("when a Machine's Node has gone away", func(t *testing.T) { - // FIXME: Resolve flaky/failing test - t.Skip("skipping until made stable") g := NewWithT(t) cluster := createCluster(g, ns.Name) mhc := newMachineHealthCheck(cluster.Namespace, cluster.Name) + mhc.Spec.NodeStartupTimeout = &metav1.Duration{Duration: 5 * time.Second} g.Expect(env.Create(ctx, mhc)).To(Succeed()) defer func(do ...client.Object) {