Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Added tests for starknet_getEvents #27

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

Trantorian1
Copy link
Member

👍 Test include the following:

  • invalid block number test
  • invalid event filter keys test
  • invalid event filter range test
  • valid call with no event key
  • valid call with single event key
  • valid call with multiple event keys

👎 Test do not include:

  • continuation token test (valid or invalid)
  • event data filtering test (valid or invalid)

Due to the high number of RPC calls included, tests had to be highly parallelized. While this has significantly reduced execution time, it still remains noticeable: this is normal.

⚠️ Also note that the high number of RPC calls might have you rate limited unless you are using a personal node for testing

Trantorian and others added 6 commits January 10, 2024 16:39
Tested getEvents on a single selector. Multiple changes to project structure had to be made along the way, both to remove dead code, improve structure and resolve concurrency issues.
Might sill add event return value / data tests in the future but this is already pretty good
@antiyro antiyro merged commit 600edc6 into KasarLabs:main Jan 11, 2024
1 check passed
@Trantorian1 Trantorian1 deleted the test/getEvents branch January 12, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants