Feat(rpc): 🐛 Fix execution tx tests for estimateMessageFee #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix estimateMessageFee Call, the new version passed multiples tests against Pathfinder and Juno for differents transactions
antiyro
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim to fix execution tx tests for the following RPC calls :
All tests pass concerning Pathfinder and Juno RPC client.
Tests has been tested against multiples tx in order to ensure answer accuracy.
Feel free to change tx params to test with you own payload message
Solve #44
Be careful, concerning simulateTransaction, there is still some small difference between a comparison Juno vs Pathfinder (Juno team is currently investigating it)