Fix bug where first call would be ignored

KatalysatorAB · Nov 17, 2015 · 9fc8bd8 · 9fc8bd8
1 parent 662e0e0
commit 9fc8bd8
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 6 deletions.
diff --git a/dist/glimr.min.js b/dist/glimr.min.js
diff --git a/src/glimr.js b/src/glimr.js
@@ -102,6 +102,7 @@
       }
 
       Glimr._loadingTags[pixelId] = [];
+      Glimr._loadingTags[pixelId].push(callback);
 
       try {
         Glimr.initGlimrId();
@@ -115,12 +116,12 @@
           Glimr._loadedTags[pixelId] = tags;
 
           var callbacks = Glimr._loadingTags[pixelId];
+          delete Glimr._loadingTags[pixelId];
+
           for (var i = 0; i < callbacks.length; i += 1) {
             callbacks[i](tags);
           }
 
-          delete Glimr._loadingTags[pixelId];
-
           if (typeof data.id === "string" && data.id !== Glimr.glimrId) {
             Glimr.glimrId = data.id;
             Glimr.setCookie();

diff --git a/test/index.php b/test/index.php
@@ -5,12 +5,30 @@
 <body>
   <script src="glimr.min.js.php"></script>
 
-  <h1 id="foo"></h1>
+  <h1 id="foo1"></h1>
+  <hr>
+  <h1 id="foo2"></h1>
 
   <script>
-    for (var i = 0; i < 10; i++) {
+    "use strict";
+
+    for (let i = 0; i < 10; i++) {
       Glimr.getTags("TESTCLIENTID", function(tags) {
-        document.getElementById("foo").innerHTML += "Got tags: <br>[" + tags.join(", ") + "]<br>";
+        document.getElementById("foo1").innerHTML += i + "<br>Got tags: <br>[" + tags.join(", ") + "]<br>";
+
+        Glimr.getTags("TESTCLIENTID", function(tags) {
+          document.getElementById("foo1").innerHTML += i + ".2<br>Got tags: <br>[" + tags.join(", ") + "]<br>";
+        });
+      });
+    }
+
+    for (let i = 0; i < 1; i++) {
+      Glimr.getTags("TESTCLIENTID2", function(tags) {
+        document.getElementById("foo2").innerHTML += i + "<br>Got tags: <br>[" + tags.join(", ") + "]<br>";
+
+        Glimr.getTags("TESTCLIENTID2", function(tags) {
+          document.getElementById("foo1").innerHTML += i + ".2<br>Got tags: <br>[" + tags.join(", ") + "]<br>";
+        });
       });
     }
   </script>