Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndexOutOfBoundsException when using an iterator #405

Merged
merged 5 commits into from
Oct 14, 2023
Merged

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Oct 13, 2023

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

Code Generators

The use of GitHub Copilot or ChatGPT is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot or ChatGPT.

Changes Made

List any changes made and/or other relevant issues.

  • Preload next page into iterator to check if there is actually more items
  • Fix status test case

https://github.com/KatsuteDev/Mal4J/actions/runs/6511183467

@Katsute Katsute self-assigned this Oct 13, 2023
@Katsute Katsute linked an issue Oct 13, 2023 that may be closed by this pull request
@Katsute Katsute added the hotfix label Oct 13, 2023
@Katsute Katsute marked this pull request as ready for review October 13, 2023 16:57
@Katsute Katsute removed the hotfix label Oct 13, 2023
@Katsute

This comment has been minimized.

@ghost

This comment has been minimized.

@Katsute
Copy link
Member Author

Katsute commented Oct 13, 2023

Iterator count matches on main and PR, safe to merge

@Katsute

This comment has been minimized.

@ghost

This comment has been minimized.

@Katsute

This comment has been minimized.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @Katsute : Passes tests and iterator count matches

@Katsute Katsute merged commit e286f32 into main Oct 14, 2023
40 checks passed
@Katsute Katsute deleted the next@4d7293b branch October 14, 2023 01:30
@ghost ghost locked and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexOutOfBoundsException on PaginatedIterator
1 participant